Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable default interface methods tests on ARM64 #35889

Merged
merged 1 commit into from
May 7, 2020
Merged

Re-enable default interface methods tests on ARM64 #35889

merged 1 commit into from
May 7, 2020

Conversation

MichalStrehovsky
Copy link
Member

These are all disabled on an unrelated bug. I couldn't dig out how this happened. If they are failing, I would want to see a high priority bug to look at them.

For some reason tiering-related tests were also disabled on the mystery bug.

@MichalStrehovsky
Re-enable default interface methods tests on ARM64
0f9a563 
These are all disabled on an unrelated bug. I couldn't dig out how this happened. If they are failing, I would want to see a high priority bug to look at them.

For some reason tiering-related tests were also disabled on the mystery bug.
@ghost
Copy link

ghost commented May 6, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

Cc @kovel on the Tier1collectible and Tier1stacktrace issues.

@jkotas
Copy link
Member

jkotas commented May 6, 2020

cc @kouvel

@safern safern mentioned this pull request May 6, 2020
Closed
@kouvel
Copy link
Member

kouvel commented May 7, 2020

The Tier1* tests seem to have been disabled in dotnet/coreclr#19213, at least from the history of that file but not sure if the mechanism of disablement had changed. I'm not aware of a reason why they should be disabled, would be good to enable. Thanks for finding it and taking care of it @MichalStrehovsky.

@MichalStrehovsky
Copy link
Member Author

The Tier1* tests seem to have been disabled in dotnet/coreclr#19213, at least from the history of that file but not sure if the mechanism of disablement had changed

Yeah, the same thing happened to the default interface tests. The pull request doesn't seem to have "delete" entries for the previous disablement mechanism so I couldn't trace this back to that place. I assume @jashook doesn't remember either.

If I can get a signoff from someone, let's merge this. The x86 CI failure is known and obviously unrelated to enabling tests on ARM64.

kouvel
kouvel approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichalStrehovsky MichalStrehovsky merged commit e8f3ac1 into dotnet:master May 7, 2020
@MichalStrehovsky MichalStrehovsky deleted the issues branch May 7, 2020 18:35
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kouvel kouvel kouvel approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalStrehovsky @jkotas @kouvel @Dotnet-GitSync-Bot